[PATCH] D104008: [ms] [llvm-ml] Warn on command-line redefinition

Eric Astor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 9 21:57:38 PDT 2021


epastor created this revision.
Herald added a subscriber: hiraditya.
epastor requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

If a macro is defined on the command line and then overridden in the source code, this is likely to be an error in the user's build system. We should warn on this.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D104008

Files:
  llvm/lib/MC/MCParser/MasmParser.cpp
  llvm/test/tools/llvm-ml/command_line_defines.asm
  llvm/test/tools/llvm-ml/command_line_defines_errors.asm

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104008.351061.patch
Type: text/x-patch
Size: 6619 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210610/cef83407/attachment-0001.bin>


More information about the llvm-commits mailing list