[PATCH] D103202: [AIX] Add traceback ssp canary bit support

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:2181
+  // There are cases that the stack protectors are not really inserted even if
+  // the attributes are on.
+  return true;
----------------
shchenz wrote:
> Will it cause some issue in unwinder if we set the ssp canary bit in the traceback table but there is no canary word in the stack?
> 
> Could you please comment @xingxue @DiggerLin @hubert.reinterpretcast 
The `FIXME` indicates a problem (as is appropriate for a `FIXME`). Even if it is possible to recover from this by more complicated logic in the unwinder, the preference should be for it to be resolved by the compiler (pay for it at compile time). The patch does not have to be blocked by the pending `FIXME`, because the bit is only set when an internal/experimental flag is set.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103202/new/

https://reviews.llvm.org/D103202