[PATCH] D102212: [AMDGPU] Add Optimize VGPR LiveRange Pass.

Carl Ritson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 9 18:59:01 PDT 2021


critson accepted this revision.
critson added a comment.
This revision is now accepted and ready to land.

LGTM, with one nit



================
Comment at: llvm/lib/Target/AMDGPU/SIOptimizeVGPRLiveRange.cpp:349
+  for (auto *MI : OldVarInfo.Kills) {
+    if (llvm::is_contained(Visited, MI->getParent()))
+      MI->addRegisterKilled(Reg, TRI);
----------------
Since Visited is a set type, I think this should be a direct test on the set, not is_contained.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102212/new/

https://reviews.llvm.org/D102212



More information about the llvm-commits mailing list