[PATCH] D103833: [demangler] Fix demangling of 'half'

[James Y Knight via Phabricator via llvm-commits]

jyknight added a comment.

In D103833#2803811 <https://reviews.llvm.org/D103833#2803811>, @stuart wrote:

> The pre-merge check failures relating to the failure to include "ItaniumDemangle.h" seem confusing to me. I cannot see how they would be caused by this change, itself: this looks on the surface to be a problem with the CI. Do I need to do anything about this?

I think this may be because you uploaded a diff without the full path or something...it somehow thinks that you renamed llvm/include/llvm/Demangle/llvm/ItaniumDemangle.h to include/llvm/Demangle/llvm/ItaniumDemangle.h. In "Download Raw Diff" it has, e.g.

  --- a/llvm/include/llvm/Demangle/ItaniumDemangle.h
  +++ b/include/llvm/Demangle/ItaniumDemangle.h

If you fix the paths in the diff, I think that'll get rid of the spurious "reformat" comments on the unchanged lines, as well.

For the actual change: using the name half here sounds fine, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103833/new/

https://reviews.llvm.org/D103833