[PATCH] D93470: [VP] Binary floating-point intrinsics.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicInst.h:401
 
+  /// Constrained FP {
+
----------------
Should these be in D93455 so they aren't unused functions?


================
Comment at: llvm/include/llvm/IR/IntrinsicInst.h:404
+  // Whether the VP intrinsic \p ID can have a rounding mode bundle.
+  static bool HasRoundingMode(Intrinsic::ID);
+
----------------
These names should be lower case per coding standards.


================
Comment at: llvm/include/llvm/IR/IntrinsicInst.h:406
+
+  // Whether the VP intrinsic \p ID can have a exception behavior
+  // bundle.
----------------
a exception -> an exception


================
Comment at: llvm/unittests/IR/VPIntrinsicTest.cpp:22
 
+#include <sstream>
+
----------------
frasercrmck wrote:
> Is this used?
This looks duplicated


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93470/new/

https://reviews.llvm.org/D93470