[PATCH] D103014: [lit] Attempt for fix tests failing because of 'warning: non-portable path to file'
Michael Kruse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 9 13:53:02 PDT 2021
Meinersbur added a comment.
The patch in the current form does both at the same time:
Path(__file__).resolve().parent.resolve()
I realize that it is actually different from
Path(__file__).parent.resolve()
but only if `__file__` (that is, the site config) itself is a symlink. Which it should not be because the site config is written by CMake which does not create it as a symlink.
I still think this is overdoing the resolving. Please remove one of them. I assume you will want to keep the outer one such that the concatenated part (`p`) is resolved as well.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103014/new/
https://reviews.llvm.org/D103014
More information about the llvm-commits
mailing list