[PATCH] D103451: [SimplifyLibCalls][NFC] Clean up LibCallSimplifier from memset+malloc into calloc transformation

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 9 13:42:49 PDT 2021


nikic added inline comments.


================
Comment at: llvm/test/Transforms/DeadStoreElimination/noop-stores.ll:350
+  ret i8* %call1
+}
+
----------------
Better include this in the other change.


================
Comment at: llvm/test/Transforms/InstCombine/memset-1.ll:32
-  ret i8* %call2
-}
-
----------------
You can leave the tests here and add a comment that this pattern is now handled by DSE in a more general way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103451/new/

https://reviews.llvm.org/D103451



More information about the llvm-commits mailing list