[PATCH] D103841: [llvm][hwasan] Decouple use of the TLS global for getting the shadow base and using the frame record feature

Leonard Chan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 9 12:51:37 PDT 2021


leonardchan added inline comments.


================
Comment at: llvm/test/Instrumentation/HWAddressSanitizer/prologue.ll:28
 ; CHECK-NOGLOBAL:   @llvm.hwasan.check.memaccess(i8* %[[A]]
+; CHECK-ZERO-OFFSET:  %[[A:[^ ]*]] = call i8* asm "", "=r,0"(i8* null)
+; CHECK-SHORT-GRANULES:  @llvm.hwasan.check.memaccess.shortgranules(i8* %[[A]]
----------------
eugenis wrote:
> CHECK-ZERO-OFFSET is never used
Woops. Meant to add a RUN case for testing a fuchsia target which should use this. Updated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103841/new/

https://reviews.llvm.org/D103841



More information about the llvm-commits mailing list