[PATCH] D103951: [NFC][Scheduler] Refactor tryCandidate to return boolean

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 9 11:45:52 PDT 2021


rampitec added a comment.

> We may change this logic further: return true only if TopCand.Reason is set (not NoCand anymore)

This seems to be better. Returning true with NoCand is misleading to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103951/new/

https://reviews.llvm.org/D103951



More information about the llvm-commits mailing list