[PATCH] D103882: [CostModel][AArch64] Make loads/stores of <vscale x 1 x eltty> expensive.

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 9 11:45:39 PDT 2021


SjoerdMeijer added a comment.

In D103882#2808633 <https://reviews.llvm.org/D103882#2808633>, @dmgreen wrote:

> It seems like a simpler overall route to remove the assert from the vectorizer, and allow it to deal with invalid costs. But I am not blocking this patch.
>
> (Although, you might want to pick a number higher than 9999, it's not particularly high. And like Sjoerd suggested giving it a name might be helpful).

Agreed with everything what Dave said. 
Removing the assert for invalid costs seems easiest to me. And I am also not blocking this, but if you want to go ahead with the 9999 we should at least define and use a constant

  CM_SVE_EXPENSIVE_HACK

or something along the lines and document what the idea and the plan is (if that isn't there already somewhere).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103882/new/

https://reviews.llvm.org/D103882



More information about the llvm-commits mailing list