[PATCH] D103292: [lld-macho] Implement ICF

Greg McGary via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 9 11:38:14 PDT 2021


gkm added a comment.

In D103292#2808544 <https://reviews.llvm.org/D103292#2808544>, @int3 wrote:

>> Yes, that's the place it's really used. Does that use justify the .75% overhead? The alternative is making an isec-to-defined map when isec->icfEquivalenceClass & (1ull << 63) .
>
> Do the other LLD backends deal with a similar problem, or is this unique to us/Mach-O's format?

Other targets just replace input sections, and don't do anything with symbols that reference replaced sections. We have reference counts on our defined symbols, but ELF and COFF do not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103292/new/

https://reviews.llvm.org/D103292



More information about the llvm-commits mailing list