[PATCH] D103975: [Attributor] Set floating point loads and stores as nofree in AANoFreeFloating

Wed Jun 9 11:08:05 PDT 2021

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LG, two nits

================
Comment at: llvm/test/Transforms/Attributor/ArgumentPromotion/byval.ll:163
+; IS__TUNIT_NPM-NEXT:    [[S_0_12:%.*]] = getelementptr [[STRUCT_SS]], %struct.ss* [[S]], i32 0, i32 1
+; IS__TUNIT_NPM-NEXT:    [[TMP3:%.*]] = load i64, i64* [[S_0_12]], align 32
 ; IS__TUNIT_NPM-NEXT:    [[C1:%.*]] = call i32 @g(i32 [[TMP2]], i64 [[TMP3]]) #[[ATTR0]]
----------------
Run the update script on this file again until the diff disappears, unfortunate non-determinism somewhere.

================
Comment at: llvm/test/Transforms/OpenMP/hide_mem_transfer_latency.ll:1
-; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: -p --function-signature --scrub-attributes
 ; RUN: opt -S -passes=openmp-opt-cgscc -aa-pipeline=basic-aa -openmp-hide-memory-transfer-latency < %s | FileCheck %s
----------------
Maybe keep the existing options as part of this commit.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103975/new/

https://reviews.llvm.org/D103975