[PATCH] D103976: [Polly][Isl] Removing explicit operator bool() from isl C++ bindings. NFC.

Riccardo Mori via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 9 11:01:25 PDT 2021


patacca created this revision.
Herald added subscribers: ormris, bmahjour, asbirlea, steven_wu, kbarton, hiraditya, nemanjai.
Herald added a reviewer: bollu.
patacca edited the summary of this revision.
patacca added a reviewer: Meinersbur.
patacca added a project: Polly.
patacca published this revision for review.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This is part of an effort to reduce the differences between the custom C++ bindings used right now by polly in `lib/External/isl/include/isl/isl-noxceptions.h` and the official isl C++ interface.

Changes made:

- Removing explicit operator bool() from all the classes in the isl C++ bindings.
- Replace each call to operator bool() to method `is_null()`.
- isl-noexceptions.h has been generated by this https://github.com/patacca/isl/commit/27396daac5a5ee8228d25511a12f4a814c92ba8f


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D103976

Files:
  polly/include/polly/ScopInfo.h
  polly/lib/Analysis/DependenceInfo.cpp
  polly/lib/Analysis/ScopBuilder.cpp
  polly/lib/Analysis/ScopInfo.cpp
  polly/lib/CodeGen/IslAst.cpp
  polly/lib/CodeGen/PPCGCodeGeneration.cpp
  polly/lib/Exchange/JSONExporter.cpp
  polly/lib/External/isl/include/isl/isl-noexceptions.h
  polly/lib/Support/ISLTools.cpp
  polly/lib/Support/SCEVAffinator.cpp
  polly/lib/Transform/DeLICM.cpp
  polly/lib/Transform/FlattenAlgo.cpp
  polly/lib/Transform/ForwardOpTree.cpp
  polly/lib/Transform/ManualOptimizer.cpp
  polly/lib/Transform/MatmulOptimizer.cpp
  polly/lib/Transform/ScheduleOptimizer.cpp
  polly/lib/Transform/ScheduleTreeTransform.cpp
  polly/lib/Transform/ZoneAlgo.cpp
  polly/unittests/DeLICM/DeLICMTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103976.350940.patch
Type: text/x-patch
Size: 61718 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210609/784001a1/attachment.bin>


More information about the llvm-commits mailing list