[PATCH] D102755: [AArch64] Add cost tests for bitreverse

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 9 10:04:23 PDT 2021


dmgreen added a comment.

Costs look good, as far as I can tell.



================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:299
+      return LegalisationCost.first * Entry->Cost + 1;
+    if (TLI->getValueType(DL, RetTy, true) != MVT::Other)
+      return LegalisationCost.first * Entry->Cost;
----------------
Should this be `if (Entry) return LegalisationCost.first * Entry->Cost;` now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102755/new/

https://reviews.llvm.org/D102755



More information about the llvm-commits mailing list