[PATCH] D103959: [LoopDeletion] Handle Phis with similar inputs from different block

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 9 09:45:59 PDT 2021


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Transforms/Scalar/LoopDeletion.cpp:250
   // we iterate in RPOT, we have already visited all its (non-latch)
   // predecessors.
+  auto GetSoleInputOnFirstIteration = [&](PHINode & PN)->Value * {
----------------
Comment needs an update.


================
Comment at: llvm/test/Transforms/LoopDeletion/eval_first_iteration.ll:664
 
 ; TODO: We can break the backedge here.
 define i32 @test_multiple_pred_2() {
----------------
TODO can be dropped.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103959/new/

https://reviews.llvm.org/D103959



More information about the llvm-commits mailing list