[PATCH] D103292: [lld-macho] Implement ICF

Wed Jun 9 09:12:15 PDT 2021

gkm added a comment.

In D103292#2807020 <https://reviews.llvm.org/D103292#2807020>, @int3 wrote:

> Could you point out the line where it's used in equalsVariable? I'm not sure I see it...

Brain fart. You are correct, there is no non-logging use.

> (I do see it being used in a non-logging sense in `foldIdentical`, though.)

Yes, that's the place it's really used. Does that use justify the .75% overhead? The alternative is making an isec-to-defined map when `isec->icfEquivalenceClass & (1ull << 63)` .

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103292/new/

https://reviews.llvm.org/D103292