[PATCH] D103968: [llvm][PowerPC] Add missing support for 'I' asm template argument modifiers

[Timm Bäder via Phabricator via llvm-commits]

tbaeder created this revision.
tbaeder added reviewers: nemanjai, tstellar.
Herald added subscribers: jdoerfert, shchenz, kbarton, hiraditya.
tbaeder requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

`I` is already documented as being supported but was not implemented. Add the missing case for it and update the documentation to reflect that it always prints nothing.

This is after review in https://bugs.llvm.org/show_bug.cgi?id=50608


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D103968

Files:
  llvm/docs/LangRef.rst
  llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp


Index: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
===================================================================
--- llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
+++ llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
@@ -359,6 +359,7 @@
       O << "0, ";
       printOperand(MI, OpNo, O);
       return false;
+    case 'I': // Print 'i' for integer constant.
     case 'U': // Print 'u' for update form.
     case 'X': // Print 'x' for indexed form.
       // FIXME: Currently for PowerPC memory operands are always loaded
Index: llvm/docs/LangRef.rst
===================================================================
--- llvm/docs/LangRef.rst
+++ llvm/docs/LangRef.rst
@@ -4892,7 +4892,8 @@
      nothing that ensures that happens, is there?
 
 - ``I``: Print the letter 'i' if the operand is an integer constant, otherwise
-  nothing. Used to print 'addi' vs 'add' instructions.
+  nothing. Used to print 'addi' vs 'add' instructions. (NOTE: This will currently
+  always print nothing)
 - ``y``: For a memory operand, prints formatter for a two-register X-form
   instruction. (Currently always prints ``r0,OPERAND``).
 - ``U``: Prints 'u' if the memory operand is an update form, and nothing


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103968.350909.patch
Type: text/x-patch
Size: 1192 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210609/763a2c89/attachment.bin>