[PATCH] D103906: Do not generate calls to the 128-bit function __multi3() on 32-bit ARM.

[Renato Golin via Phabricator via llvm-commits]

rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.

Right, I think it's a bit clearer now.

1. We inherited the lack of 128-bit arithmetic from GCC and other targets, so currently, there isn't a default place we can get them from.
2. The current version of compiler-rt doesn't have them, nor does libgcc, so if users want them, they have to link their own libs.
3. We want to implement them, long term, in compiler-rt, which we also want to make the default in LLVM for all supported targets.

Given the time-frame of item (3) and the fact that, today, the compiler is generating code that doesn't link (without users providing the symbols themselves), I think this change is correct for the time being. I'm creating a bug to address this and adding people here to the CC list.

Otherwise, this patch LGTM, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103906/new/

https://reviews.llvm.org/D103906