[PATCH] D102755: [AArch64] Add cost tests for bitreverse

[Caroline via Phabricator via llvm-commits]

CarolineConcatto added a comment.

Hey @Rin,
I don't think you need bitreverse-cost-model.ll, you can use only bitreverse.ll. 
Why some costs are not being changed in bitreverse.ll?



================
Comment at: llvm/test/Analysis/CostModel/AArch64/bitreverse-cost-model.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_analyze_test_checks.py
+; RUN: opt -cost-model -analyze -cost-kind=code-size -mtriple=aarch64-none-eabi < %s | FileCheck %s --check-prefix=SIZE
+
----------------
Do you need to use

```
-cost-kind=code-size -mtriple=aarch64-none-eabi 
```
?

I believe you can have the same command as bitreverse.ll, no?

nit: 
s/%s --check-prefix=SIZE/ %s /


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102755/new/

https://reviews.llvm.org/D102755