[PATCH] D103836: [ARM][NEON] Combine base address updates for vld1Ndup intrinsics
Dave Green via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 9 02:08:39 PDT 2021
dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.
I got confused by the _fixed vs _register vs _UPD for a while, but I see that's pre-existing :)
Nice patch. Thanks for doing it. LGTM
================
Comment at: llvm/lib/Target/ARM/ARMExpandPseudoInsts.cpp:582
Register DstReg = MI.getOperand(OpIdx++).getReg();
if(TableEntry->RealOpc == ARM::VLD2DUPd8x2 ||
TableEntry->RealOpc == ARM::VLD2DUPd16x2 ||
----------------
Feel free to format this as it suggests. And maybe make a function/lambda for "is VLD2 DUP" too, if it's used below too.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103836/new/
https://reviews.llvm.org/D103836
More information about the llvm-commits
mailing list