[PATCH] D100375: [yaml2obj] Enable support for parsing 64-bit XCOFF.

EsmeYi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 9 01:48:59 PDT 2021


Esme added a comment.

As for the need of testing the string table, I will add such test after `llvm-readobj --string-table` is implemented.



================
Comment at: llvm/lib/ObjectYAML/XCOFFEmitter.cpp:287
       }
       if (PaddingSize > 0)
         W.OS.write_zeros(PaddingSize);
----------------
jhenderson wrote:
> Didn't notice this before when reviewing the 32-bit implementation: why is this check here? Same comment for other such checks.
As Zheng's comment in D95505


> We don't have to call write_zeros if PaddingSize is 0




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100375/new/

https://reviews.llvm.org/D100375



More information about the llvm-commits mailing list