[PATCH] D103455: [yaml2obj] Add support for writing the long symbol name.

EsmeYi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 9 01:29:28 PDT 2021


Esme added a comment.

In D103455#2807169 <https://reviews.llvm.org/D103455#2807169>, @jhenderson wrote:

> In D103455#2805561 <https://reviews.llvm.org/D103455#2805561>, @Esme wrote:
>
>> Addressed comments except dumping the raw string table.
>> It seems llvm-readobj can't dump the raw string table for XCOFF, I have to find another tool to do this.
>
> I think it would make a lot of sense to add string table dumping to llvm-readobj. It's generic enough that you could probably get away with implementing it for multiple file formats too (e.g. for ELF it would dump all SHT_STRTAB sections), but initially, you can just implement it for XCOFF. I'd use a switch name as simple as `--string-table` or possibly `--string-tables`.

Thanks, it's a good idea to implement the option for llvm-readobj. I will do this in the future.
As far as I know, there is a system tool `dump` under AIX (https://www.ibm.com/docs/en/aix/7.1?topic=d-dump-command), which can print the raw string table.

  bash-5.0$ yaml2obj llvm/test/tools/yaml2obj/XCOFF/long-symbol-name.yaml -o test.o
  bash-5.0$ dump -cv test.o 
  
  test.o:
  
                          ***String Table Information***
           Offset     Name
  
               4   .longname

However, the test in this patch can't dump the string table yet unless `llvm-readobj --string-table` is implemented.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103455/new/

https://reviews.llvm.org/D103455



More information about the llvm-commits mailing list