[PATCH] D101819: [DRAFT][M68k][GloballSel] Adding initial GlobalISel infrastructure

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp:3134
+      reportTranslationError(*MF, *TPC, *ORE, R);
+    }
   }
----------------
(style) Drop unnecessary braces


================
Comment at: llvm/lib/Target/M68k/GlSel/M68kCallLowering.cpp:32
+    return false;
+  }
+  MIRBuilder.buildInstr(M68k::RTS);
----------------
(style) Drop unnecessary braces


================
Comment at: llvm/lib/Target/M68k/GlSel/M68kInstructionSelector.cpp:77
+    return true;
+  }
+
----------------
(style) Drop unnecessary braces and move comment above if()


================
Comment at: llvm/lib/Target/M68k/GlSel/M68kLegalizerInfo.h:27
+} // end namespace llvm
+#endif
----------------
(style) Missing // LLVM_LIB_TARGET_M68K_GLSEL_M68KLEGALIZERINFO_H


================
Comment at: llvm/test/CodeGen/M68k/GlobalISel/irtranslator-ret.ll:8
+}
\ No newline at end of file

----------------
add newline


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101819/new/

https://reviews.llvm.org/D101819