[PATCH] D103146: [NFC][XCOFF] Use yaml2obj in llvm-objdump/XCOFF/section-headers.test instead of binary files.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/section-headers.test:64
+# RUN: yaml2obj %s --docnum=3 -o %t-truncate.o
+# RUN: %python -c "with open('%t-truncate.o', 'r+b') as input: input.truncate(20)"
+# RUN: not llvm-objdump --section-headers %t-truncate.o 2>&1 \
----------------
https://reviews.llvm.org/harbormaster/unit/view/775092/ suggests there might be a problem here. This will expand to a Windows path with only single backslashes in which will cause problems when python tries to consume it on some machines (because `\<char>` might be an escape char). I think there's a simple fix: use `%/t` instead, as that replaces all backslashes with forward slashes in the substitution.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103146/new/

https://reviews.llvm.org/D103146