[PATCH] D103292: [lld-macho] Implement ICF

[Greg McGary via Phabricator via llvm-commits]

gkm added a comment.

In D103292#2804387 <https://reviews.llvm.org/D103292#2804387>, @int3 wrote:

> Haven't dug into the details yet, but a few high-level thoughts:
>
> - The logging code is fairly extensive. Is it really necessary to commit it? If we are leaving it in, could we perhaps cut out InputSection::defined and symbolicate addresses by doing a linear/binary search for the matching symbol?

FYI, `defined` is used extensively from `equalsVariable()` during the segregation algorithm. It is integral to the operation of ICF, regardless of logging. Removing `defined` in favor of reverse symbol-table lookups will severely degrade ICF performance.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103292/new/

https://reviews.llvm.org/D103292