[PATCH] D102870: [RFC] [WIP] CodeGen: Print/parse LLTs in MachineMemOperands

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 8 16:21:50 PDT 2021


arsenm added a comment.

In D102870#2791326 <https://reviews.llvm.org/D102870#2791326>, @thegameg wrote:

> In general I think the syntax looks fine. Not sure I get how hard it is to get rid of the parenthesis, but if we end up changing many tests, we should probably do it only once.
>
> Suggestion: maybe add a flag to facilitate the test transition for downstream users? (for `CHECK` lines, assuming there would be some tests that check for things like `load 4` instead of `load (s32)`)

I think this will just contribute to the neverending accumulation of compatibility junk to avoid test updates. At least for globalisel tests, more manual intervention is needed to fixup cases where the scalar is inappropriate. We'll need some memory type verifiers for G_* instructions


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102870/new/

https://reviews.llvm.org/D102870



More information about the llvm-commits mailing list