[PATCH] D103841: [llvm][hwasan] Decouple use of the TLS global for getting the shadow base and using the frame record feature

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 8 12:05:22 PDT 2021


eugenis added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:1050
+
+  if (!WithFrameRecord && ShadowBase)
     return;
----------------
I think this will break Linux kernel build.
They use -fsanitize=kernel-hwaddress with one of
```
-hwasan-instrument-with-calls=1
```
or
```
-hwasan-mapping-offset=
```
The assumption here is that InTls == 0 means there is no thread slot, and therefore no frame recording.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103841/new/

https://reviews.llvm.org/D103841



More information about the llvm-commits mailing list