[PATCH] D93659: [AIX][XCOFF] emit vector info of traceback table.

Digger Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 8 10:53:02 PDT 2021


DiggerLin marked 3 inline comments as done.
DiggerLin added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCMachineFunctionInfo.h:135
+  /// ParamTypes - Store all the paramters type.
+  SmallVector<ParamType, 32> ParamtersType;
 
----------------
DiggerLin wrote:
> jasonliu wrote:
> > Does this store the parameter types when the parameter is on stack? Right now, it doesn't look like so. And this sounds like we are trying to store all paramters including the one on stack.
> > Could we add a test case for testing parameters on stack?
> we do not store the  parameter types when the parameter is on stack.
in the llvm/test/CodeGen/PowerPC/aix-emit-tracebacktable.ll , there are some parameter are stored on stack.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93659/new/

https://reviews.llvm.org/D93659



More information about the llvm-commits mailing list