[PATCH] D103704: [ARM] Extend narrow values to allow using truncating scatters

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 8 10:50:12 PDT 2021


dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/MVEGatherScatterLowering.cpp:641-642
+      InputTy->isIntOrIntVectorTy()) {
+    InputTy = InputTy->getWithNewBitWidth(
+        128 / cast<FixedVectorType>(InputTy)->getNumElements());
+    Input = Builder.CreateZExt(Input, InputTy);
----------------
samtebbs wrote:
> What happens here if `InputTy` is an integer (as I assume is allowed by `isIntOrIntVectorTy()`)?
We will already have ruled out scalar integer types, we know InputTy will be some sort of vector. So isIntOrIntVectorTy is really just saying "is it an integer vector type"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103704/new/

https://reviews.llvm.org/D103704



More information about the llvm-commits mailing list