[PATCH] D103866: GlobalISel: Avoid use of G_INSERT in insertParts

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 8 10:19:25 PDT 2021


arsenm added a comment.

In D103866#2805907 <https://reviews.llvm.org/D103866#2805907>, @bogner wrote:

> Some of the test case updates show a lot more code coming out of the legalizer, which is a little bit concerning, but it looks like that's mostly with very unusual types like `s112` (though it looks like it comes up a bit for things like `s24` as well). That's probably okay though, as I'm guessing later passes will see all the constants and clean this up without too much trouble. Most of the cases with more normal types look like strict improvements I think.

Some of these cases (especially the larger ones) actually show legalizing to completion now, whereas before they were failing on s24 inserts


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103866/new/

https://reviews.llvm.org/D103866



More information about the llvm-commits mailing list