[PATCH] D103901: [NFC][XCOFF] Replace structs FileHeader32/SectionHeader32 with constants.
Sean Fertile via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 8 09:21:14 PDT 2021
sfertile accepted this revision as: sfertile.
sfertile added a comment.
This revision is now accepted and ready to land.
One comment but otherwise LGTM.
================
Comment at: llvm/include/llvm/BinaryFormat/XCOFF.h:30
+constexpr size_t FileHeaderSize32 = 20;
+constexpr size_t FileHeaderSize64 = 24;
+constexpr size_t SectionHeaderSize32 = 40;
----------------
The constants for the 64-bit XCOFF headers/relocs aren't used yet so they shouldn't be added in this patch. You can add them in the yaml changes that use them.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103901/new/
https://reviews.llvm.org/D103901
More information about the llvm-commits
mailing list