[PATCH] D102627: [LTO] Support new PM in ThinLTOCodeGenerator.

Tue Jun 8 09:06:03 PDT 2021

fhahn added inline comments.

================
Comment at: llvm/test/ThinLTO/X86/diagnostic-handler-remarks.ll:23
 ; YAML1-NEXT: Name:            Inlined
-; YAML1-NEXT: Function:        main
+; YAML1-NEXT: Function:        foo
 ; YAML1-NEXT: Args:
----------------
thegameg wrote:
> fhahn wrote:
> > steven_wu wrote:
> > > Why this test case needs to be changed for switch PM?
> > The new PM does inlining a bit different, that's where the difference comes from I think. Perhaps @thegameg has any additional insight in the test case?
> Looks like we went from `foo inlined into main` to `bar inlined into foo`. Maybe we now have two remarks: `bar inlined into foo` + `foo inlined into main`?
Yep, but I don't think this change is really relevant for the switch to the new PM, as different inlining decisions are just a side-effect of using the new PM. In the latest version I pinned the remarks tests to use the legacy PM and updated `llvm/test/ThinLTO/X86/newpm-basic.ll` to check that `-use-new-pm` works as expected.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102627/new/

https://reviews.llvm.org/D102627