[PATCH] D99481: [InstCombine] Fix miscompile on GEP+load to icmp fold (PR45210)

[Hyeongyu Kim via Phabricator via llvm-commits]

hyeongyukim added a comment.

In D99481#2801515 <https://reviews.llvm.org/D99481#2801515>, @efriedma wrote:

> I don't think the revised change really solves the problem.  The reason you end up with dead instructions is the "return nullptr;" at the end of the function, around line 402.  The new code doesn't seem related to that.  If we narrow the cases where the generate the lshr+and, the infloop might trigger less frequently, but it doesn't really solve the general problem.

You're right.
I changed my code to add lshr+and only if those two instructions are meaningful. 
Could you review my code again?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99481/new/

https://reviews.llvm.org/D99481