[PATCH] D103815: [LLD][ELF] Fix PT_LOAD program header creation for NO_LOAD sections

[Konstantin Schwarz via Phabricator via llvm-commits]

kschwarz marked 2 inline comments as done.
kschwarz added a comment.

Thanks for your comments! I've applied the suggested formatting changes.

Indeed the comment you referenced

> [...] ELF gets a .bss style noload, alloc, no contents section. [...]

seems to disagree with the documentation, where a NOLOAD section can have contents.
I'm not too familiar with the GNU ld internals, so I'm not sure what the effect of clearing SEC_HAS_CONTENTS is.

What would be your suggestion how to proceed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103815/new/

https://reviews.llvm.org/D103815