[PATCH] D99621: [CMake][Compiler-rt] Make it possible to configure standalone compiler-rt without `LLVMConfig.cmake`.

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added inline comments.


================
Comment at: compiler-rt/cmake/Modules/CompilerRTMockLLVMCMakeConfig.cmake:35
+  # compiler.
+  if (COMPILER_RT_DEFAULT_TARGET_ONLY)
+    if (NOT "${CMAKE_C_COMPILER_TARGET}" STREQUAL "")
----------------
Is there a reason this is guarded by COMPILER_RT_DEFAULT_TARGET_ONLY? Until now we have been cross-compiling compiler-rt without this setting and relied on CMAKE_C_COMPILER_TARGET being used instead of the host triple (which is the default triple for our cross-compilers).

For now I can change our build scripts to set COMPILER_RT_DEFAULT_TARGET_ONLY when cross-compiling, but shouldn't it also work without COMPILER_RT_DEFAULT_TARGET_ONLY set?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99621/new/

https://reviews.llvm.org/D99621