[PATCH] D103805: [flang] Define the runtime API for CPU_TIME

Tue Jun 8 02:00:04 PDT 2021

jeanPerier accepted this revision.
jeanPerier added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: flang/runtime/time-intrinsic.h:12
+
+#ifndef FORTRAN_RUNTIME_TIME_INTRINSIC_H_
+#define FORTRAN_RUNTIME_TIME_INTRINSIC_H_
----------------
rovka wrote:
> klausler wrote:
> > I would consider putting this into the header file with miscellaneous intrinsics... were it not for the problem of SYSTEM_CLOCK (16.9.186), which will also need a home, and whose API might be messy.  DATE_AND_TIME will also need to go here.
> Yes, my intention was to add SYSTEM_CLOCK here as well. As you point out, DATE_AND_TIME also fits.
FYI, there is an old draft of DATE_AND_TIME in fir-dev: https://github.com/flang-compiler/f18-llvm-project/blob/fir-dev/flang/runtime/clock.h and https://github.com/flang-compiler/f18-llvm-project/blob/fir-dev/flang/runtime/clock.cpp.
It's missing support for the `VALUES` argument and lack windows support. I'll upstream it in these new file when your patch is in.
It is the only intrinsic for which something was done in fir-dev only.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103805/new/

https://reviews.llvm.org/D103805