[PATCH] D101421: [DebugInfo] Enable CodeView DebugInfo for basic block sections

[TaoPan via Phabricator via llvm-commits]

TaoPan added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:2947
     return;
+  if (MI->getParent()->isBeginSection() && !MI->getParent()->isEntryBlock())
+    return;
----------------
rnk wrote:
> Please add a comment here.
> 
> Also, are you sure this is the right condition? Aren't there MBBs that do not begin sections but belong to a non-primary section?
Thanks!
I added comment and changed condition to the MachineFunction which has the MachineInstr has BB sections and the MachineBasicBlock which has the MachineInstr is not entry block, how do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101421/new/

https://reviews.llvm.org/D101421