[llvm] 310d2b4 - [yaml2obj] Fix buildbot-issue-4886

via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 7 20:03:42 PDT 2021


Author: Esme-Yi
Date: 2021-06-08T03:00:52Z
New Revision: 310d2b4957c8c11387354c58d15e3249971accc7

URL: https://github.com/llvm/llvm-project/commit/310d2b4957c8c11387354c58d15e3249971accc7
DIFF: https://github.com/llvm/llvm-project/commit/310d2b4957c8c11387354c58d15e3249971accc7.diff

LOG: [yaml2obj] Fix buildbot-issue-4886

XCOFFEmitter.cpp:67:16: runtime error: null pointer passed as argument 2,
which is declared to never be null

Added: 
    

Modified: 
    llvm/lib/ObjectYAML/XCOFFEmitter.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/ObjectYAML/XCOFFEmitter.cpp b/llvm/lib/ObjectYAML/XCOFFEmitter.cpp
index 8d2c17c76e0dc..c4a4e1ffea120 100644
--- a/llvm/lib/ObjectYAML/XCOFFEmitter.cpp
+++ b/llvm/lib/ObjectYAML/XCOFFEmitter.cpp
@@ -64,7 +64,8 @@ class XCOFFWriter {
 static void writeName(StringRef StrName, support::endian::Writer W) {
   char Name[XCOFF::NameSize];
   memset(Name, 0, XCOFF::NameSize);
-  memcpy(Name, StrName.data(), StrName.size());
+  char SrcName[] = "";
+  memcpy(Name, StrName.size() ? StrName.data() : SrcName, StrName.size());
   ArrayRef<char> NameRef(Name, XCOFF::NameSize);
   W.write(NameRef);
 }


        


More information about the llvm-commits mailing list