[PATCH] D103459: [Demangle][Rust] Parse path backreferences

Tomasz Miąsko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 7 15:05:54 PDT 2021


tmiasko marked an inline comment as done.
tmiasko added inline comments.


================
Comment at: llvm/lib/Demangle/RustDemangle.cpp:510-512
+  case 'B':
+    demangleBackref([&] { demangleType(); });
+    break;
----------------
dblaikie wrote:
> Maybe split this in two - add the two different places for backrefs separately, with separate tests? Oh, three different places (also demangleConst)?
I split patch into D103847 and D103848, while adding extra tests that exercise recursion limit in each production.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103459/new/

https://reviews.llvm.org/D103459



More information about the llvm-commits mailing list