[PATCH] D103821: [lld/mac] Add reexports after reexporter to inputFiles

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 7 14:28:46 PDT 2021


thakis added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:872
   // Initialize symbols.
   exportingFile = isImplicitlyLinked(installName) ? this : this->umbrella;
   if (const load_command *cmd = findCommand(hdr, LC_DYLD_INFO_ONLY)) {
----------------
One subtlety (mostly independent of this patch) here is that isImplicitlyLinked() sees the installName before it might have been modified by `$ld$` symbols. But since those usually don't change the directory that should be fine in practice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103821/new/

https://reviews.llvm.org/D103821



More information about the llvm-commits mailing list