[PATCH] D103843: Parallel-libs/.clang-tidy: Remove broken config and simplify existing one to use inheritance from the root .clang-tidy

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 7 14:25:42 PDT 2021


dblaikie created this revision.
dblaikie added a reviewer: arsenm.
dblaikie requested review of this revision.
Herald added subscribers: llvm-commits, aheejin, wdng.
Herald added a project: LLVM.

parallel-libs/.clang-tidy seems to have been broken from the start (but
unused) due to using "lowerCase" as a format name (rather than
"lower_case") which actually crashes clang-tidy. But since no code is in
that directory, all uses of clang-tidy used the override in
acxxel/.clang-tidy.

So to simplify things, I've sunk the acxxel format down/up into the
general format, and changed it to use inheritance from the llvm monorepo
root .clang-tidy for simplicity/so it can inherit features from there.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D103843

Files:
  parallel-libs/.clang-tidy
  parallel-libs/acxxel/.clang-tidy


Index: parallel-libs/acxxel/.clang-tidy
===================================================================
--- parallel-libs/acxxel/.clang-tidy
+++ /dev/null
@@ -1,17 +0,0 @@
-Checks: '-*,clang-diagnostic-*,llvm-*,-llvm-header-guard,misc-*,-misc-unused-parameters,readability-identifier-naming'
-CheckOptions:
-  - key:             readability-identifier-naming.ClassCase
-    value:           CamelCase
-  - key:             readability-identifier-naming.EnumCase
-    value:           CamelCase
-  - key:             readability-identifier-naming.FunctionCase
-    value:           camelBack
-  - key:             readability-identifier-naming.MemberCase
-    value:           CamelCase
-  - key:             readability-identifier-naming.ParameterCase
-    value:           CamelCase
-  - key:             readability-identifier-naming.UnionCase
-    value:           CamelCase
-  - key:             readability-identifier-naming.VariableCase
-    value:           CamelCase
-
Index: parallel-libs/.clang-tidy
===================================================================
--- parallel-libs/.clang-tidy
+++ parallel-libs/.clang-tidy
@@ -1,17 +1,2 @@
-Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,readability-identifier-naming'
-CheckOptions:
-  - key:             readability-identifier-naming.ClassCase
-    value:           CamelCase
-  - key:             readability-identifier-naming.EnumCase
-    value:           CamelCase
-  - key:             readability-identifier-naming.FunctionCase
-    value:           lowerCase
-  - key:             readability-identifier-naming.MemberCase
-    value:           CamelCase
-  - key:             readability-identifier-naming.ParameterCase
-    value:           CamelCase
-  - key:             readability-identifier-naming.UnionCase
-    value:           CamelCase
-  - key:             readability-identifier-naming.VariableCase
-    value:           CamelCase
-
+Checks: '-llvm-header-guard'
+InheritParentConfig: true


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103843.350416.patch
Type: text/x-patch
Size: 2002 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210607/f37f72a7/attachment.bin>


More information about the llvm-commits mailing list