[PATCH] D103821: [lld/mac] Add reexports after reexporter to inputFiles

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 7 14:03:53 PDT 2021


thakis added a comment.

Thanks!

In D103821#2803804 <https://reviews.llvm.org/D103821#2803804>, @int3 wrote:

> Makes sense (I think!) -- if I understand correctly, for the implicit linking stuff, by setting the exportingFile to point to an implicitly-linked dylib, we ensure that `DylibFile::isReferenced()` returns true since the symbols are now registered as belonging to that dylib, thus making the dead dylib stripping logic in Writer.cpp work.

Right, that's my understanding too :) I think this is already covered by lld/test/MachO/implicit-dylib.s if I read that test right.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103821/new/

https://reviews.llvm.org/D103821



More information about the llvm-commits mailing list