[PATCH] D103821: [lld/mac] Add reexports after reexporter to inputFiles

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 7 12:55:05 PDT 2021


thakis added a comment.

Ok, I removed the `inputFiles.insert(reexport)` in `loadReexport()` which after adding in the ctor is no longer needed. (It's also not harmful thanks to the `ordinal` deduper and dead dylib stripper in Writer).

I think we still need exportingFile (and isImplicitlyLinked for it): We want to resolve against the reexport, but when targeting an older version then either:

1. the reexport is unused and now auto-stripped
2. it assumes the reexporter's install name via an `$ld$` magic symbol

and it's then removed due to the code in Writer that merges ordinals.

Does that make sense?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103821/new/

https://reviews.llvm.org/D103821



More information about the llvm-commits mailing list