[PATCH] D103254: Preserve more MD_mem_parallel_loop_access and MD_access_group in SROA

[Mark Mendell via Phabricator via llvm-commits]

mmendell added inline comments.


================
Comment at: llvm/test/Transforms/SROA/mem-par-metadata-sroa-cast.ll:8-9
+; CHECK: entry:
+; CHECK: load i32, i32* {{.*}}, !llvm.access.group [[DISTINCT:![0-9]*]]
+; CHECK: load i32, i32* {{.*}}, !llvm.access.group [[DISTINCT]]
+; CHECK: ret void
----------------
Meinersbur wrote:
> This tests the `presplitLoadsAndStores` case. Shouldn't it also have split the store?
The store is replaced with:
  %0 = bitcast i32 %X371 to float
  %1 = bitcast i32 %X373 to float
Should I add that to the LIT test?  The important part was the loss of the llvm.access.group from the store


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103254/new/

https://reviews.llvm.org/D103254