[llvm] be51737 - Fix "not all control paths return a value" MSVC warning. NFCI.

[David Blaikie via llvm-commits]

I'd expect this would produce a -Wswitch warning (if the old code had
a fully covered switch and this change causes the switch to become
only partially covered) - usually we address this sort of warning by
adding an unreachable after the switch.

On Sat, Jun 5, 2021 at 11:42 AM Simon Pilgrim via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
>
>
> Author: Simon Pilgrim
> Date: 2021-06-05T19:42:00+01:00
> New Revision: be51737f59875fd8b3451fc7a8363be1283e0ca2
>
> URL: https://github.com/llvm/llvm-project/commit/be51737f59875fd8b3451fc7a8363be1283e0ca2
> DIFF: https://github.com/llvm/llvm-project/commit/be51737f59875fd8b3451fc7a8363be1283e0ca2.diff
>
> LOG: Fix "not all control paths return a value" MSVC warning. NFCI.
>
> Added:
>
>
> Modified:
>     llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.cpp
>
> Removed:
>
>
>
> ################################################################################
> diff  --git a/llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.cpp b/llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.cpp
> index 2840657f18c22..0462c3628ed39 100644
> --- a/llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.cpp
> +++ b/llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.cpp
> @@ -123,7 +123,7 @@ unsigned RISCVVType::encodeVTYPE(RISCVII::VLMUL VLMUL, unsigned SEW,
>
>  std::pair<unsigned, bool> RISCVVType::decodeVLMUL(RISCVII::VLMUL VLMUL) {
>    switch (VLMUL) {
> -  case RISCVII::VLMUL::LMUL_RESERVED:
> +  default:
>      llvm_unreachable("Unexpected LMUL value!");
>    case RISCVII::VLMUL::LMUL_1:
>    case RISCVII::VLMUL::LMUL_2:
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits