[llvm] 937c4cf - Fix implicit fall through compiler warning. NFCI.

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 7 10:49:08 PDT 2021


This appears to change behavior - any chance of test coverage?

On Sun, Jun 6, 2021 at 6:17 AM Simon Pilgrim via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
>
>
> Author: Simon Pilgrim
> Date: 2021-06-06T13:45:11+01:00
> New Revision: 937c4cffd02420607ada23d3d25078df9bf553cb
>
> URL: https://github.com/llvm/llvm-project/commit/937c4cffd02420607ada23d3d25078df9bf553cb
> DIFF: https://github.com/llvm/llvm-project/commit/937c4cffd02420607ada23d3d25078df9bf553cb.diff
>
> LOG: Fix implicit fall through compiler warning. NFCI.
>
> Added:
>
>
> Modified:
>     llvm/lib/ExecutionEngine/Interpreter/ExternalFunctions.cpp
>
> Removed:
>
>
>
> ################################################################################
> diff  --git a/llvm/lib/ExecutionEngine/Interpreter/ExternalFunctions.cpp b/llvm/lib/ExecutionEngine/Interpreter/ExternalFunctions.cpp
> index 3aa77557862e4..8d4a198f90c77 100644
> --- a/llvm/lib/ExecutionEngine/Interpreter/ExternalFunctions.cpp
> +++ b/llvm/lib/ExecutionEngine/Interpreter/ExternalFunctions.cpp
> @@ -166,6 +166,7 @@ static void *ffiValueFor(Type *Ty, const GenericValue &AV,
>            return ArgDataPtr;
>          }
>        }
> +      break;
>      case Type::FloatTyID: {
>        float *FloatPtr = (float *) ArgDataPtr;
>        *FloatPtr = AV.FloatVal;
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list