[PATCH] D103748: [LoopUnroll] Clamp unroll count to MaxTripCount

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/one required change.



================
Comment at: llvm/lib/Transforms/Utils/LoopUnroll.cpp:735
         // block which ends in ExitingBI, not neccessarily the loop.
-        if (ExactTripCount && j != ExactTripCount)
           return false;
----------------
Please add back the j != ExactTripCount bit.

I don't have a firm counter example, but the mixture of exitBI specific exact counts and loop maximum counts makes me nervous here.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103748/new/

https://reviews.llvm.org/D103748