[PATCH] D103696: [XCOFF][AIX] Add support for XCOFF 64 bit Object files

[Sean Fertile via Phabricator via llvm-commits]

sfertile added a comment.

Thanks for working on this. My first suggestion is we need to break up this patch to make it smaller and easier to review. The natural place to partition it is the llvm-readobj functionality.  I don't think the YAML tools support generating 64-bit XCOFF objects yet, but we can add a precompiled object file as test input.



================
Comment at: llvm/tools/llvm-readobj/XCOFFDumper.cpp:108
   if (Obj.is64Bit())
-    llvm_unreachable("64-bit relocation output not implemented!");
+    //llvm_unreachable("64-bit relocation output not implemented!");
+    printRelocations64(Obj.sections64());
----------------
Please remove the unreachable instead of commenting it out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103696/new/

https://reviews.llvm.org/D103696