[PATCH] D103818: [NFC][X86] lowerVECTOR_SHUFFLE(): drop FIXME about widening to i128 (YMM half) element type
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 7 09:14:10 PDT 2021
lebedev.ri updated this revision to Diff 350321.
lebedev.ri retitled this revision from "[X86] lowerVECTOR_SHUFFLE(): allow widening shuffle to have i128 (YMM half) element type" to "[NFC][X86] lowerVECTOR_SHUFFLE(): drop FIXME about widening to i128 (YMM half) element type".
lebedev.ri edited the summary of this revision.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103818/new/
https://reviews.llvm.org/D103818
Files:
llvm/lib/Target/X86/X86ISelLowering.cpp
Index: llvm/lib/Target/X86/X86ISelLowering.cpp
===================================================================
--- llvm/lib/Target/X86/X86ISelLowering.cpp
+++ llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -18444,7 +18444,7 @@
// Try to collapse shuffles into using a vector type with fewer elements but
// wider element types. We cap this to not form integers or floating point
- // elements wider than 64 bits, but it might be interesting to form i128
+ // elements wider than 64 bits. It does not seem beneficial to form i128
// integers to handle flipping the low and high halves of AVX 256-bit vectors.
SmallVector<int, 16> WidenedMask;
if (VT.getScalarSizeInBits() < 64 && !Is1BitVector &&
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103818.350321.patch
Type: text/x-patch
Size: 715 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210607/01595b61/attachment.bin>
More information about the llvm-commits
mailing list