[PATCH] D103823: [TableGen] Fix ProfileFoldOpInit so that parameters are named consistently [NFC]

Paul C. Anagnostopoulos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 7 09:01:33 PDT 2021


Paul-C-Anagnostopoulos created this revision.
Paul-C-Anagnostopoulos added a reviewer: RKSimon.
Herald added a subscriber: hiraditya.
Paul-C-Anagnostopoulos requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This patch fixed the names of the parameters in ProfileFoldOpInit() so they match the order of the parameters in calls and related functions. This did not cause a bug because the mixed-up parameters all had the same types and their order was irrelevant.

See https://bugs.llvm.org/show_bug.cgi?id=50595


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D103823

Files:
  llvm/lib/TableGen/Record.cpp


Index: llvm/lib/TableGen/Record.cpp
===================================================================
--- llvm/lib/TableGen/Record.cpp
+++ llvm/lib/TableGen/Record.cpp
@@ -1470,9 +1470,8 @@
           ", " + MHS->getAsString() + ", " + RHS->getAsString() + ")");
 }
 
-static void ProfileFoldOpInit(FoldingSetNodeID &ID, Init *A, Init *B,
-                              Init *Start, Init *List, Init *Expr,
-                              RecTy *Type) {
+static void ProfileFoldOpInit(FoldingSetNodeID &ID, Init *Start, Init *List,
+                              Init *A, Init *B, Init *Expr, RecTy *Type) {
   ID.AddPointer(Start);
   ID.AddPointer(List);
   ID.AddPointer(A);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103823.350317.patch
Type: text/x-patch
Size: 679 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210607/e508edd4/attachment.bin>


More information about the llvm-commits mailing list